Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add new colours #4632

Merged
merged 9 commits into from
Mar 29, 2022
Merged

Add new colours #4632

merged 9 commits into from
Mar 29, 2022

Conversation

jroebu14
Copy link
Contributor

@jroebu14 jroebu14 commented Mar 29, 2022

Partially resolves bbc/simorgh#9943

Overall change:
Adds new colours introduced by Chameleon to the psammead-styles package. Colours are being moved from this PR bbc/simorgh#9937 and will be referenced from this package.

Versions and updates changelogs of all affected packages.

Code changes:

  • all psammead-styles code changes found here in the packages/utilities/psammead-styles/src/colours.js file
  • fixes a bug where bumping packages using a list of packages did not work. code changes here in file scripts/utilities/getPackagePath/index.js

  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@jroebu14 jroebu14 marked this pull request as ready for review March 29, 2022 09:04
@jroebu14 jroebu14 self-assigned this Mar 29, 2022
Copy link
Contributor

@rebeccamcginn rebeccamcginn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colours are changing to red+white for the pagination component but good to have these in place for future usage 👍

@jroebu14 jroebu14 merged commit ad6d398 into latest Mar 29, 2022
@jroebu14 jroebu14 deleted the add-new-colours branch March 29, 2022 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Topic Pagination] Front End
3 participants